Bug 19695
| Summary: | webkit_web_view_get_settings clashes with gtk_widget_get_settings | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Christian Dywan <christian> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, mrobinson |
| Priority: | P2 | Keywords: | Gtk |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
Christian Dywan
webkit_web_view_get_settings clashes with gtk_widget_get_settings.
This is not necessarily a problem in the C interface, however it might be confusing and more importantly in bindings that map something like foo.getSettings or foo.get_settings.
I suggest to rename the accessor and property to actually refer to web_settings instead of settings.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Martin Robinson
Carlos, here's another bindings issue that we should figure out how to fix for WebKit.
Carlos Garcia Campos
webkit_web_view_get_web_settings() makes sense in WebKit1 where settings object is WebKitWebSettings, but in WebKit2 is WebKitSettings. Don't have bindings a way to deal with this?