Bug 196949

Summary: Stop using hyphenationFactor
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alex Christensen 2019-04-15 17:19:36 PDT 
Stop using hyphenationFactor
Comment 1 Alex Christensen 2019-04-15 17:21:25 PDT 
Created attachment 367479 [details]
Patch
Comment 2 Alex Christensen 2019-04-15 17:21:27 PDT 
<rdar://problem/49779594>
Comment 3 Geoffrey Garen 2019-04-15 17:25:04 PDT 
Comment on attachment 367479 [details]
Patch

r=me

How did you test the visual result? Is this covered by regression tests?
Comment 4 Alex Christensen 2019-04-15 18:15:49 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 367479 [details]
> Patch
> 
> r=me
> 
> How did you test the visual result? 
I tested that the visual result was good without this call when working on r241124.  I actually saw no effect when adding this, and I considered it unnecessary but added it anyway based on feedback from you and out of abundance of caution. 
> Is this covered by regression tests?
No.
Comment 5 WebKit Commit Bot 2019-04-15 18:43:35 PDT 
Comment on attachment 367479 [details]
Patch

Clearing flags on attachment: 367479

Committed r244319: <https://trac.webkit.org/changeset/244319>
Comment 6 WebKit Commit Bot 2019-04-15 18:43:37 PDT 
All reviewed patches have been landed.  Closing bug.