Bug 196947

Summary: ews-build should clearly indicate flaky test failures
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch lforschler: review+

Aakash Jain
Reported 2019-04-15 16:08:41 PDT
API tests has various flaky failures. Since ews-build runs API tests multiple times, it can notice flaky tests. ews-build should clearly indicate flaky test in the UI when it identifies a flaky test. This would help in easily identifying flaky tests and getting them fixed.
Attachments
Patch (2.84 KB, patch)
2019-04-15 16:09 PDT, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-15 16:09:49 PDT
Created attachment 367473 [details] Patch
Lucas Forschler
Comment 2 2019-04-15 16:33:15 PDT
Comment on attachment 367473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367473&action=review r=me after checking the first/second variable name. > Tools/BuildSlaveSupport/ews-build/steps.py:802 > + self._addToLog('stderr', '\nFailures in API Test second run: {}'.format(first_run_failures)) I think this should be second_run_failures.
Aakash Jain
Comment 3 2019-04-15 16:36:28 PDT
Committed r244306: <https://trac.webkit.org/changeset/244306>
Radar WebKit Bug Importer
Comment 4 2019-04-15 16:37:18 PDT
<rdar://problem/49923241>
Note You need to log in before you can comment on or make changes to this bug.