Bug 196947 - ews-build should clearly indicate flaky test failures
Summary: ews-build should clearly indicate flaky test failures
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-04-15 16:08 PDT by Aakash Jain
Modified: 2019-04-15 16:37 PDT (History)
5 users (show)

See Also:

Patch (2.84 KB, patch)
2019-04-15 16:09 PDT, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-15 16:08:41 PDT
API tests has various flaky failures. Since ews-build runs API tests multiple times, it can notice flaky tests. ews-build should clearly indicate flaky test in the UI when it identifies a flaky test. This would help in easily identifying flaky tests and getting them fixed.
Comment 1 Aakash Jain 2019-04-15 16:09:49 PDT
Created attachment 367473 [details]
Comment 2 Lucas Forschler 2019-04-15 16:33:15 PDT
Comment on attachment 367473 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=367473&action=review

r=me after checking the first/second variable name.

> Tools/BuildSlaveSupport/ews-build/steps.py:802
> +        self._addToLog('stderr', '\nFailures in API Test second run: {}'.format(first_run_failures))

I think this should be second_run_failures.
Comment 3 Aakash Jain 2019-04-15 16:36:28 PDT
Committed r244306: <https://trac.webkit.org/changeset/244306>
Comment 4 Radar WebKit Bug Importer 2019-04-15 16:37:18 PDT