Bug 196940

Summary: Using Tools/Scripts/clean-webkit should not install requests
Product: WebKit Reporter: Dean Johnson <dean_johnson>
Component: Tools / TestsAssignee: Dean Johnson <dean_johnson>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dewei_zhu, ews-watchlist, glenn, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dewei_zhu: review+

Dean Johnson
Reported 2019-04-15 15:17:51 PDT
Importing webkitpy.port.base automatically starts installing `requests` into Tools/Scripts/thirdparty/autoinstalled. Since the Port class is integral to many scripts which will not be doing uploads of WebKit test results, we should avoid auto-installing unnecessary modules like `requests` until they're actually needed.
Attachments
Patch (3.18 KB, patch)
2019-04-15 16:08 PDT, Dean Johnson 		dewei_zhu: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Johnson
Comment 1 2019-04-15 16:08:51 PDT
Created attachment 367472 [details] Patch
Jonathan Bedard
Comment 2 2019-04-15 16:13:40 PDT
Unofficial r+.
Lucas Forschler
Comment 3 2019-04-15 16:17:21 PDT
Comment on attachment 367472 [details] Patch r=me if EWS passes.
WebKit Commit Bot
Comment 4 2019-04-15 17:00:55 PDT
Comment on attachment 367472 [details] Patch Clearing flags on attachment: 367472 Committed r244310: <https://trac.webkit.org/changeset/244310>
WebKit Commit Bot
Comment 5 2019-04-15 17:00:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-04-15 17:02:30 PDT
<rdar://problem/49924067>
Note You need to log in before you can comment on or make changes to this bug.