Bug 196940 - Using Tools/Scripts/clean-webkit should not install requests
Summary: Using Tools/Scripts/clean-webkit should not install requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Johnson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-15 15:17 PDT by Dean Johnson
Modified: 2019-04-16 22:37 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.18 KB, patch)
2019-04-15 16:08 PDT, Dean Johnson 		dewei_zhu: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Johnson 2019-04-15 15:17:51 PDT 
Importing webkitpy.port.base automatically starts installing `requests` into Tools/Scripts/thirdparty/autoinstalled. Since the Port class is integral to many scripts which will not be doing uploads of WebKit test results, we should avoid auto-installing unnecessary modules like `requests` until they're actually needed.
Comment 1 Dean Johnson 2019-04-15 16:08:51 PDT 
Created attachment 367472 [details]
Patch
Comment 2 Jonathan Bedard 2019-04-15 16:13:40 PDT 
Unofficial r+.
Comment 3 Lucas Forschler 2019-04-15 16:17:21 PDT 
Comment on attachment 367472 [details]
Patch

r=me if EWS passes.
Comment 4 WebKit Commit Bot 2019-04-15 17:00:55 PDT 
Comment on attachment 367472 [details]
Patch

Clearing flags on attachment: 367472

Committed r244310: <https://trac.webkit.org/changeset/244310>
Comment 5 WebKit Commit Bot 2019-04-15 17:00:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-15 17:02:30 PDT 
<rdar://problem/49924067>