Bug 196923

Summary: Several structures and enums in the Yarr interpreter can be shrunk
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Robin Morisset 2019-04-15 11:46:59 PDT 
YarrOp: 88 -> 80
RegularExpression: 40 -> 32
ByteTerm: 56 -> 48
PatternTerm: 56 -> 48
Comment 1 Robin Morisset 2019-04-15 11:51:17 PDT 
Created attachment 367436 [details]
Patch

trivial shrinking of enums and reordering of the fields of structs.
Comment 2 EWS Watchlist 2019-04-15 11:53:57 PDT 
Attachment 367436 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/yarr/YarrInterpreter.h:380:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2019-04-15 13:39:17 PDT 
Comment on attachment 367436 [details]
Patch

Clearing flags on attachment: 367436

Committed r244286: <https://trac.webkit.org/changeset/244286>
Comment 4 WebKit Commit Bot 2019-04-15 13:39:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-15 13:40:19 PDT 
<rdar://problem/49915584>