Summary: | [CMake] WebCore derived sources should only be referenced inside WebCore | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, commit-queue, mcatanzaro | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 196704 | ||||||||
Attachments: |
|
Description
Don Olmstead
2019-04-14 07:15:07 PDT
Created attachment 367419 [details]
Patch
Comment on attachment 367419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367419&action=review > Source/cmake/WebKitMacros.cmake:136 > + if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}") Here we reference WebCore-specific variable from macro which is used in other targets. Looks suspicious. > Source/cmake/WebKitMacros.cmake:142 > + source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}") Ditto. (In reply to Konstantin Tokarev from comment #2) > Comment on attachment 367419 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367419&action=review > > > Source/cmake/WebKitMacros.cmake:136 > > + if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}") > > Here we reference WebCore-specific variable from macro which is used in > other targets. Looks suspicious. > > > Source/cmake/WebKitMacros.cmake:142 > > + source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}") > > Ditto. Removing in https://bugs.webkit.org/show_bug.cgi?id=196916 Created attachment 367456 [details]
Patch
Remove changes to WebKitMacros.
Comment on attachment 367456 [details] Patch Clearing flags on attachment: 367456 Committed r244292: <https://trac.webkit.org/changeset/244292> All reviewed patches have been landed. Closing bug. |