Bug 196904

Summary: [CMake] WebCore derived sources should only be referenced inside WebCore
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 196704    
Attachments:
Description Flags
Patch
annulen: review+
Patch none

Don Olmstead
Reported 2019-04-14 07:15:07 PDT
Anything outside of Source/JavaScriptCore should NOT be touching JavaScriptCore's derived sources.
Attachments
Patch (44.78 KB, patch)
2019-04-15 09:43 PDT, Don Olmstead 		annulen: review+
DetailsFormatted DiffDiff
Patch (44.33 KB, patch)
2019-04-15 14:02 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-04-15 09:43:30 PDT
Created attachment 367419 [details] Patch
Konstantin Tokarev
Comment 2 2019-04-15 09:55:36 PDT
Comment on attachment 367419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367419&action=review > Source/cmake/WebKitMacros.cmake:136 > + if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}") Here we reference WebCore-specific variable from macro which is used in other targets. Looks suspicious. > Source/cmake/WebKitMacros.cmake:142 > + source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}") Ditto.
Don Olmstead
Comment 3 2019-04-15 10:44:15 PDT
(In reply to Konstantin Tokarev from comment #2) > Comment on attachment 367419 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367419&action=review > > > Source/cmake/WebKitMacros.cmake:136 > > + if (NOT _file MATCHES "${WebCore_DERIVED_SOURCES_DIR}") > > Here we reference WebCore-specific variable from macro which is used in > other targets. Looks suspicious. > > > Source/cmake/WebKitMacros.cmake:142 > > + source_group("DerivedSources" REGULAR_EXPRESSION "${WebCore_DERIVED_SOURCES_DIR}") > > Ditto. Removing in https://bugs.webkit.org/show_bug.cgi?id=196916
Don Olmstead
Comment 4 2019-04-15 14:02:24 PDT
Created attachment 367456 [details] Patch Remove changes to WebKitMacros.
WebKit Commit Bot
Comment 5 2019-04-15 14:46:42 PDT
Comment on attachment 367456 [details] Patch Clearing flags on attachment: 367456 Committed r244292: <https://trac.webkit.org/changeset/244292>
WebKit Commit Bot
Comment 6 2019-04-15 14:46:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.