Bug 196889

Summary:

Web Inspector: Heap: logging an object from a snapshot shouldn't use the "special" style if the object is reachable

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2019-04-12 18:23:13 PDT

`window.foo.bar.baz` vs `Heap Snapshot Object (%s)`

Comment 1 Radar WebKit Bug Importer 2019-04-12 18:24:43 PDT

<rdar://problem/49870693>

Comment 2 Devin Rousso 2019-04-12 18:28:46 PDT

Created attachment 367365 [details]
Patch

Comment 3 Joseph Pecoraro 2019-04-15 11:19:14 PDT

Comment on attachment 367365 [details]
Patch

r=me, Nice!

Comment 4 WebKit Commit Bot 2019-04-15 11:47:43 PDT

Comment on attachment 367365 [details]
Patch

Clearing flags on attachment: 367365

Committed r244275: <https://trac.webkit.org/changeset/244275>

Comment 5 WebKit Commit Bot 2019-04-15 11:47:45 PDT

All reviewed patches have been landed.  Closing bug.