Bug 196883

Summary: Enable modern compatibility mode by default in WKWebView on some devices
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit APIAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, bfulgham, commit-queue, graouts, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix macOS builds none

Wenson Hsieh
Reported 2019-04-12 16:02:57 PDT
<rdar://problem/49864527>
Attachments
Patch (15.13 KB, patch)
2019-04-12 16:23 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix macOS builds (15.11 KB, patch)
2019-04-12 16:42 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-04-12 16:23:24 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2019-04-12 16:42:58 PDT
Created attachment 367357 [details] Fix macOS builds
Tim Horton
Comment 3 2019-04-12 17:24:18 PDT
Comment on attachment 367357 [details] Fix macOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=367357&action=review > Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:294 > + static bool isAppleApplication = applicationBundleStartsWith("com.apple."_s); > + return isAppleApplication; This seems a bit broad as mentioned elsewhere.
Wenson Hsieh
Comment 4 2019-04-12 19:15:03 PDT
Comment on attachment 367357 [details] Fix macOS builds View in context: https://bugs.webkit.org/attachment.cgi?id=367357&action=review >> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:294 >> + return isAppleApplication; > > This seems a bit broad as mentioned elsewhere. Unfortunately, yes 😞. I filed <rdar://problem/49871194> to track this.
WebKit Commit Bot
Comment 5 2019-04-12 20:54:16 PDT
Comment on attachment 367357 [details] Fix macOS builds Clearing flags on attachment: 367357 Committed r244239: <https://trac.webkit.org/changeset/244239>
WebKit Commit Bot
Comment 6 2019-04-12 20:54:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.