Bug 196881

Summary: Run JetStream2 as part of the bytecode cache tests
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: NEW    
Severity: Normal CC: cdumez, ews-watchlist, rniwa, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 196865, 196878, 196880    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
patch for landing
none
patch for landing none

Tadeu Zagallo
Reported 2019-04-12 15:13:06 PDT
...
Attachments
Patch (4.97 KB, patch)
2019-04-12 15:25 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
patch for landing (4.99 KB, patch)
2019-04-16 04:29 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
patch for landing (5.08 KB, patch)
2019-04-16 04:51 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-04-12 15:25:52 PDT
Created attachment 367350 [details] Patch
Saam Barati
Comment 2 2019-04-13 09:14:47 PDT
Comment on attachment 367350 [details] Patch r=me
Saam Barati
Comment 3 2019-04-13 09:15:14 PDT
Do we not fail this today?
Saam Barati
Comment 4 2019-04-13 09:16:34 PDT
Also does this work when preparing the tests for iOS devices? Will it package up all of JS2?
Tadeu Zagallo
Comment 5 2019-04-13 10:31:44 PDT
(In reply to Saam Barati from comment #3) > Do we not fail this today? Yes, there are a couple other patches that need to land first. I've updated the dependencies to reflect that. (In reply to Saam Barati from comment #4) > Also does this work when preparing the tests for iOS devices? Will it > package up all of JS2? That's a good question, I will check that.
Tadeu Zagallo
Comment 6 2019-04-16 04:29:06 PDT
Created attachment 367528 [details] patch for landing
Tadeu Zagallo
Comment 7 2019-04-16 04:46:24 PDT
(In reply to Tadeu Zagallo from comment #5) > (In reply to Saam Barati from comment #3) > > Do we not fail this today? > > Yes, there are a couple other patches that need to land first. I've updated > the dependencies to reflect that. > > (In reply to Saam Barati from comment #4) > > Also does this work when preparing the tests for iOS devices? Will it > > package up all of JS2? > > That's a good question, I will check that. Everything works fine. My only concern is that the test takes nearly 7 minutes on debug builds...
Tadeu Zagallo
Comment 8 2019-04-16 04:51:04 PDT
Created attachment 367530 [details] patch for landing Fix missing comma in run-javascriptcore-tests
Saam Barati
Comment 9 2019-04-16 10:13:35 PDT
(In reply to Tadeu Zagallo from comment #7) > (In reply to Tadeu Zagallo from comment #5) > > (In reply to Saam Barati from comment #3) > > > Do we not fail this today? > > > > Yes, there are a couple other patches that need to land first. I've updated > > the dependencies to reflect that. > > > > (In reply to Saam Barati from comment #4) > > > Also does this work when preparing the tests for iOS devices? Will it > > > package up all of JS2? > > > > That's a good question, I will check that. > > Everything works fine. My only concern is that the test takes nearly 7 > minutes on debug builds... You could edit the benchmark and re-check it in modifying some of the longer running tests to do less inner iterations
Note You need to log in before you can comment on or make changes to this bug.