Summary: | [ATK] Implement AtkComponentIface scroll_to methods | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aboxhall, agomez, apinheiro, bugs-noreply, cfleizach, clopez, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, ltilve, mcatanzaro, samuel_white, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | Gtk, InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=148935 | ||||||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-04-12 05:07:44 PDT
Created attachment 367315 [details]
Patch
Created attachment 367318 [details]
Patch
Created attachment 367320 [details]
Patch
Comment on attachment 367320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367320&action=review > Tools/gtk/jhbuild.modules:284 > + <meson id="atk" mesonargs="-Dintrospection=no"> meson.build:1:0: ERROR: Value no is not boolean (true or false). Needs to be =false, didn't you test this? > Tools/gtk/jhbuild.modules:290 > + <meson id="at-spi2-core" mesonargs="-Dintrospection=no"> Ditto Created attachment 367927 [details]
Patch for landing
(In reply to Michael Catanzaro from comment #5) > Comment on attachment 367320 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367320&action=review > > > Tools/gtk/jhbuild.modules:284 > > + <meson id="atk" mesonargs="-Dintrospection=no"> > > meson.build:1:0: ERROR: Value no is not boolean (true or false). > > Needs to be =false, didn't you test this? meson.build:1:0: ERROR: Value "false" for combo option "introspection" is not one of the choices. Possible choices are: "yes", "no", "auto". > > Tools/gtk/jhbuild.modules:290 > > + <meson id="at-spi2-core" mesonargs="-Dintrospection=no"> > > Ditto Created attachment 367928 [details]
Patch for landing
Comment on attachment 367928 [details] Patch for landing Clearing flags on attachment: 367928 Committed r244538: <https://trac.webkit.org/changeset/244538> All reviewed patches have been landed. Closing bug. |