Bug 196856

Summary: [ATK] Implement AtkComponentIface scroll_to methods
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, agomez, apinheiro, bugs-noreply, cfleizach, clopez, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, ltilve, mcatanzaro, samuel_white, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=148935
Attachments:
Description Flags
Patch
none
Patch
none
Patch
mcatanzaro: review+
Patch for landing
none
Patch for landing none

Description Carlos Garcia Campos 2019-04-12 05:07:44 PDT
There's scroll_to and scroll_to_point since ATK 2.30
Comment 1 Radar WebKit Bug Importer 2019-04-12 05:07:55 PDT
<rdar://problem/49848600>
Comment 2 Carlos Garcia Campos 2019-04-12 05:12:57 PDT
Created attachment 367315 [details]
Patch
Comment 3 Carlos Garcia Campos 2019-04-12 05:54:34 PDT
Created attachment 367318 [details]
Patch
Comment 4 Carlos Garcia Campos 2019-04-12 06:23:07 PDT
Created attachment 367320 [details]
Patch
Comment 5 Michael Catanzaro 2019-04-12 09:01:29 PDT
Comment on attachment 367320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367320&action=review

> Tools/gtk/jhbuild.modules:284
> +  <meson id="atk" mesonargs="-Dintrospection=no">

meson.build:1:0: ERROR:  Value no is not boolean (true or false).

Needs to be =false, didn't you test this?

> Tools/gtk/jhbuild.modules:290
> +  <meson id="at-spi2-core" mesonargs="-Dintrospection=no">

Ditto
Comment 6 Carlos Garcia Campos 2019-04-22 01:00:52 PDT
Created attachment 367927 [details]
Patch for landing
Comment 7 Carlos Garcia Campos 2019-04-22 01:43:53 PDT
(In reply to Michael Catanzaro from comment #5)
> Comment on attachment 367320 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367320&action=review
> 
> > Tools/gtk/jhbuild.modules:284
> > +  <meson id="atk" mesonargs="-Dintrospection=no">
> 
> meson.build:1:0: ERROR:  Value no is not boolean (true or false).
> 
> Needs to be =false, didn't you test this?

meson.build:1:0: ERROR:  Value "false" for combo option "introspection" is not one of the choices. Possible choices are: "yes", "no", "auto".

> > Tools/gtk/jhbuild.modules:290
> > +  <meson id="at-spi2-core" mesonargs="-Dintrospection=no">
> 
> Ditto
Comment 8 Carlos Garcia Campos 2019-04-22 01:46:27 PDT
Created attachment 367928 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-04-23 03:47:51 PDT
Comment on attachment 367928 [details]
Patch for landing

Clearing flags on attachment: 367928

Committed r244538: <https://trac.webkit.org/changeset/244538>
Comment 10 WebKit Commit Bot 2019-04-23 03:47:53 PDT
All reviewed patches have been landed.  Closing bug.