Bug 196833

Summary: Update 'Save Image' to more clear instructions
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
wenson_hsieh: review+
Patch none

Megan Gardner
Reported 2019-04-11 15:28:30 PDT
Update 'Save Image' to more clear instructions
Attachments
Patch (5.91 KB, patch)
2019-04-11 15:33 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (4.07 KB, patch)
2019-04-11 15:50 PDT, Megan Gardner 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch (3.20 KB, patch)
2019-04-11 16:06 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-04-11 15:33:28 PDT
Created attachment 367253 [details] Patch
Megan Gardner
Comment 2 2019-04-11 15:33:52 PDT
<rdar://problem/47446845>
Wenson Hsieh
Comment 3 2019-04-11 15:42:38 PDT
Comment on attachment 367253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review > Source/WebCore/en.lproj/Localizable.strings:629 > -/* Title for Save Image action button */ > -"Save Image" = "Save Image"; > +/* Title for Add to Photos action button */ > +"Add to Photos" = "Add to Photos"; I think these are in sorted order. IIRC, Tools/Scripts/update-webkit-localizable-strings should do the trick. > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95 > +localizedStrings["Add to Photos"] = "Add to Photos"; Is this related? I think this is a separate web inspector feature... > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:951 > + contextMenu.appendItem(WI.UIString("Add to Photos"), () => { (Here too)
Wenson Hsieh
Comment 4 2019-04-11 15:45:08 PDT
Comment on attachment 367253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review >> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95 >> +localizedStrings["Add to Photos"] = "Add to Photos"; > > Is this related? I think this is a separate web inspector feature... This is the feature Devin added in WI that allows us to snapshot a DOM node. We don't want to change this string.
Megan Gardner
Comment 5 2019-04-11 15:50:33 PDT
Created attachment 367254 [details] Patch
Wenson Hsieh
Comment 6 2019-04-11 15:52:18 PDT
Comment on attachment 367254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367254&action=review > Source/WebInspectorUI/ChangeLog:15 > + Let's remove this ChangeLog entry.
Megan Gardner
Comment 7 2019-04-11 16:06:16 PDT
Created attachment 367258 [details] Patch
Megan Gardner
Comment 8 2019-04-11 16:06:47 PDT
Sorry, I meant to, I guess I missed it.
WebKit Commit Bot
Comment 9 2019-04-11 17:58:56 PDT
Comment on attachment 367258 [details] Patch Clearing flags on attachment: 367258 Committed r244205: <https://trac.webkit.org/changeset/244205>
Note You need to log in before you can comment on or make changes to this bug.