Bug 196832

Summary:

Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2019-04-11 15:22:43 PDT

# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Timelines tab
3. enable the JavaScript Allocations timeline
4. select the JavaScript Allocations timeline
5. take a heap snapshot

Comment 1 Devin Rousso 2019-04-11 15:22:56 PDT

<rdar://problem/49828862>

Comment 2 Devin Rousso 2019-04-11 15:23:28 PDT

Created attachment 367249 [details]
Patch

Comment 3 Simon Fraser (smfr) 2019-04-11 15:27:32 PDT

Comment on attachment 367249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367249&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UserInterface/Controllers/TimelineManager.js:

Word here please like "This regressed when I discombobulated the rotary encabulator".

Comment 4 Devin Rousso 2019-04-11 15:29:52 PDT

Created attachment 367251 [details]
Patch

Comment 5 WebKit Commit Bot 2019-04-11 15:56:45 PDT

Comment on attachment 367251 [details]
Patch

Clearing flags on attachment: 367251

Committed r244199: <https://trac.webkit.org/changeset/244199>

Comment 6 WebKit Commit Bot 2019-04-11 15:56:47 PDT

All reviewed patches have been landed.  Closing bug.