Summary: | Extract UTI mapping and allow for additions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||
Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dean Jackson
2019-04-11 12:08:02 PDT
Created attachment 367231 [details]
Patch
Comment on attachment 367231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367231&action=review > Source/WebKit/Shared/ios/UTIMappings.mm:42 > +NSString *UTIforMIMEType(const String& mimeType) Seems like this should fold into UTIUtilities Created attachment 367247 [details]
Patch
Comment on attachment 367247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367247&action=review > Source/WebCore/platform/network/mac/UTIUtilities.mm:89 > + static const auto map = makeNeverDestroyed([] { Why not just go straight to UTI instead of using CoreServices, if you're already hardcoding? Committed r244201: <https://trac.webkit.org/changeset/244201> Comment on attachment 367247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367247&action=review > Source/WebCore/platform/network/mac/UTIUtilities.mm:112 > + return String(adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassFilenameExtension, mapEntry->value.createCFString().get(), nil)).get()); I don’t think the explicit String constructor is needed here. > Source/WebCore/platform/network/mac/UTIUtilities.mm:121 > + return String(type.get()); I don’t think the explicit String constructor is needed here. Committed r244247: <https://trac.webkit.org/changeset/244247> Comment on attachment 367247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367247&action=review >> Source/WebCore/platform/network/mac/UTIUtilities.mm:121 >> + return String(type.get()); > > I don’t think the explicit String constructor is needed here. Fixed. |