Bug 196817

Summary: [GTK][WPE] Fix pacman install-dependencies packages
Product: WebKit Reporter: Ludovico de Nittis <ludovico.denittis>
Component: Tools / TestsAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, aperez, clopez, commit-queue, csaavedra, ews-watchlist, lforschler, ltilve, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ludovico de Nittis
Reported 2019-04-11 06:30:10 PDT
Trying to install the WebKit dependencies on Arch Linux I found the following errors: - `python3-setuptools` is actually called `python-setuptools`. - `ruby-highline` is only available on AUR and not in the official repositories. - `libv4l-devel` is incorporated in `v4l-utils`.
Attachments
Patch (2.62 KB, patch)
2019-04-11 06:39 PDT, Ludovico de Nittis 		no flags
DetailsFormatted DiffDiff
Patch (2.94 KB, patch)
2019-04-11 06:42 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
Patch (3.64 KB, patch)
2019-04-11 06:53 PDT, Ludovico de Nittis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ludovico de Nittis
Comment 1 2019-04-11 06:39:01 PDT
Created attachment 367215 [details] Patch
Claudio Saavedra
Comment 2 2019-04-11 06:42:15 PDT
Created attachment 367216 [details] Patch
Claudio Saavedra
Comment 3 2019-04-11 06:43:37 PDT
Comment on attachment 367216 [details] Patch Sorry, I didn't realize you were going to submit a patch as well.
Claudio Saavedra
Comment 4 2019-04-11 06:45:58 PDT
Comment on attachment 367215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367215&action=review > Tools/wpe/install-dependencies:194 > + # Note: apache-mod_bw, ruby-json and ruby-highline are available in the AUR If you look at the wpe script, there is a long explanation on how to get packages from AUR. Please bring this script in sync with that one (as I had done in mine).
Claudio Saavedra
Comment 5 2019-04-11 06:46:28 PDT
(In reply to Claudio Saavedra from comment #4) > Comment on attachment 367215 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367215&action=review > > > Tools/wpe/install-dependencies:194 > > + # Note: apache-mod_bw, ruby-json and ruby-highline are available in the AUR > > If you look at the wpe script, there is a long explanation on how to get > packages from AUR. Please bring this script in sync with that one (as I had > done in mine). Not my day, it seems. I meant the gtk script.
Ludovico de Nittis
Comment 6 2019-04-11 06:53:01 PDT
Created attachment 367217 [details] Patch
Ludovico de Nittis
Comment 7 2019-04-11 06:53:50 PDT
Don't worry Claudio, I wasn't expecting someone to issue a patch in just 10 minutes :)
Claudio Saavedra
Comment 8 2019-04-12 00:22:03 PDT
lgtm
WebKit Commit Bot
Comment 9 2019-04-12 06:29:47 PDT
Comment on attachment 367217 [details] Patch Clearing flags on attachment: 367217 Committed r244214: <https://trac.webkit.org/changeset/244214>
WebKit Commit Bot
Comment 10 2019-04-12 06:29:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-04-12 06:30:20 PDT
<rdar://problem/49849756>
Note You need to log in before you can comment on or make changes to this bug.