Summary: | Unable to run system Safari with trunk WebKit | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | aakash_jain, achristensen, ap, beidson, commit-queue, ews-watchlist, ggaren, simon.fraser, webkit-bug-importer | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar, NeedsReduction | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2019-04-10 11:59:15 PDT
Created attachment 367147 [details]
Patch
Comment on attachment 367147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367147&action=review > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:46 > +#define DYLD_MACOS_VERSION_FIRST_WITH_EXCEPTIONS_FOR_RELATED_WEBVIEWS_USING_DIFFERENT_DATA_STORES 0 I don't think this will fix our open source friends' problem. We need to define the last version and use DYLD_MACOSX_VERSION_10_14 > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:86 > +enum class AssumeSafariIsAlwaysLinkedOnAfter { No, Yes }; : bool (In reply to Alex Christensen from comment #3) > Comment on attachment 367147 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367147&action=review > > > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:46 > > +#define DYLD_MACOS_VERSION_FIRST_WITH_EXCEPTIONS_FOR_RELATED_WEBVIEWS_USING_DIFFERENT_DATA_STORES 0 > > I don't think this will fix our open source friends' problem. We need to > define the last version and use DYLD_MACOSX_VERSION_10_14 I believe it works because of the change I made to linkedOnAfter which special-cases 0 as sdkVersion. > > > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:86 > > +enum class AssumeSafariIsAlwaysLinkedOnAfter { No, Yes }; > > : bool (In reply to Chris Dumez from comment #4) > (In reply to Alex Christensen from comment #3) > > Comment on attachment 367147 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=367147&action=review > > > > > Source/WebKit/UIProcess/Cocoa/VersionChecks.h:46 > > > +#define DYLD_MACOS_VERSION_FIRST_WITH_EXCEPTIONS_FOR_RELATED_WEBVIEWS_USING_DIFFERENT_DATA_STORES 0 > > > > I don't think this will fix our open source friends' problem. We need to > > define the last version and use DYLD_MACOSX_VERSION_10_14 > > I believe it works because of the change I made to linkedOnAfter which > special-cases 0 as sdkVersion. As it is working for me without internal changes. Created attachment 367149 [details]
Patch
Comment on attachment 367149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367149&action=review > Source/WebKit/ChangeLog:20 > + - In the header, DYLD_IOS_VERSION_* / DYLD_MACOS_VERSION_* constants are 0 when building with the I explained this in the Changelog here. Comment on attachment 367149 [details] Patch Clearing flags on attachment: 367149 Committed r244146: <https://trac.webkit.org/changeset/244146> All reviewed patches have been landed. Closing bug. Reverted r244146 for reason: Caused a few DeviceOrientation API test failures on iOS Committed r244170: <https://trac.webkit.org/changeset/244170> Created attachment 367196 [details]
Patch
Created attachment 367199 [details]
Patch
Created attachment 367202 [details]
Patch
Comment on attachment 367202 [details] Patch Attachment 367202 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11838498 New failing tests: fast/device-orientation/device-orientation-request-permission-granted.html fast/device-orientation/device-motion-request-permission-denied.html fast/device-orientation/device-motion-request-permission-granted.html fast/device-orientation/device-orientation-request-permission-user-gesture.html http/tests/events/device-orientation-motion-secure-context.html fast/device-orientation/device-orientation-request-permission-denied.html fast/device-orientation/device-motion-request-permission-user-gesture.html Created attachment 367208 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 367246 [details]
Patch
Comment on attachment 367246 [details] Patch Clearing flags on attachment: 367246 Committed r244203: <https://trac.webkit.org/changeset/244203> All reviewed patches have been landed. Closing bug. |