| Summary: | WebCore should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | ap, commit-queue, don.olmstead, ews-watchlist, Hironori.Fujii, keith_miller, rniwa, webkit-bug-importer, ysuzuki | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Ross Kirsling
2019-04-09 22:19:11 PDT
Created attachment 367102 [details]
Patch
Comment on attachment 367102 [details] Patch The good news is that this patch gets WinCairo (regardless of clang-cl or regular cl) through compiling WebCore. The bad news is that we hit one heck of a nasty-looking linking error: > [5/1068] Linking CXX static library lib64\WebCore.lib > FAILED: lib64/WebCore.lib > cmd.exe /C "cd . && C:\PROGRA~2\MICROS~4\2019\COMMUN~1\VC\Tools\MSVC\1420~1.275\bin\Hostx64\x64\link.exe /lib /nologo /machine:x64 /out:lib64\WebCore.lib @CMakeFiles\WebCore.rsp && cd ." > lib64\WebCore.lib : fatal error LNK1248: image size (1002E82C0) exceeds maximum allowable size (FFFFFFFF) > ninja: build stopped: subcommand failed. Comment on attachment 367102 [details] Patch Attachment 367102 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11826610 New failing tests: fast/dom/gc-9.html Created attachment 367106 [details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 367102 [details] Patch Attachment 367102 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11826593 New failing tests: fast/dom/gc-9.html Created attachment 367107 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 367108 [details]
Patch
Comment on attachment 367108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367108&action=review r=me provided the following comments are addressed. > Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:31 > + JSCanvasRenderingContext2D* jsCanvasRenderingContext = JSC::jsCast<JSCanvasRenderingContext2D*>(handle.slot()->asCell()); > + void* root = jsCanvasRenderingContext->wrapped().canvas().opaqueRoot(); We don't wanna directly call Node::opaqueRoot like this. Just include JSNode.h instead. > Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:37 > - visitor.addOpaqueRoot(root(wrapped().canvas())); > + visitor.addOpaqueRoot(wrapped().canvas().opaqueRoot()); Ditto. JSNodeCustom.h rather. Created attachment 367127 [details]
Patch for landing
Comment on attachment 367127 [details] Patch for landing Clearing flags on attachment: 367127 Committed r244115: <https://trac.webkit.org/changeset/244115> All reviewed patches have been landed. Closing bug. |