| Summary: | [CMake] JavaScriptCore derived sources should only be referenced inside JavaScriptCore | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, commit-queue, mcatanzaro | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 196704 | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2019-04-09 12:25:52 PDT
Created attachment 367355 [details]
Patch
Comment on attachment 367355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367355&action=review > ChangeLog:9 > + to support moving the JavaScriptCore derived sources outside of a shared directory. Does it change anything besides variable name? Seems like both JavaScriptCore_DERIVED_SOURCES_DIR and DERIVED_SOURCES_JAVASCRIPTCORE_DIR point to the same path now Comment on attachment 367355 [details] Patch Clearing flags on attachment: 367355 Committed r244245: <https://trac.webkit.org/changeset/244245> All reviewed patches have been landed. Closing bug. (In reply to Konstantin Tokarev from comment #2) > Comment on attachment 367355 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367355&action=review > > > ChangeLog:9 > > + to support moving the JavaScriptCore derived sources outside of a shared directory. > > Does it change anything besides variable name? Seems like both > JavaScriptCore_DERIVED_SOURCES_DIR and DERIVED_SOURCES_JAVASCRIPTCORE_DIR > point to the same path now I'm using WinCairo as the canary in the coal mine here. It overrides the directory. |