Bug 196742

Summary: [CMake] JavaScriptCore derived sources should only be referenced inside JavaScriptCore
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 196704    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2019-04-09 12:25:52 PDT
Anything outside of Source/JavaScriptCore should NOT be touching JavaScriptCore's derived sources.
Attachments
Patch (38.35 KB, patch)
2019-04-12 16:16 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-04-12 16:16:47 PDT
Created attachment 367355 [details] Patch
Konstantin Tokarev
Comment 2 2019-04-13 19:26:11 PDT
Comment on attachment 367355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367355&action=review > ChangeLog:9 > + to support moving the JavaScriptCore derived sources outside of a shared directory. Does it change anything besides variable name? Seems like both JavaScriptCore_DERIVED_SOURCES_DIR and DERIVED_SOURCES_JAVASCRIPTCORE_DIR point to the same path now
WebKit Commit Bot
Comment 3 2019-04-14 06:50:06 PDT
Comment on attachment 367355 [details] Patch Clearing flags on attachment: 367355 Committed r244245: <https://trac.webkit.org/changeset/244245>
WebKit Commit Bot
Comment 4 2019-04-14 06:50:08 PDT
All reviewed patches have been landed. Closing bug.
Don Olmstead
Comment 5 2019-04-14 07:12:55 PDT
(In reply to Konstantin Tokarev from comment #2) > Comment on attachment 367355 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367355&action=review > > > ChangeLog:9 > > + to support moving the JavaScriptCore derived sources outside of a shared directory. > > Does it change anything besides variable name? Seems like both > JavaScriptCore_DERIVED_SOURCES_DIR and DERIVED_SOURCES_JAVASCRIPTCORE_DIR > point to the same path now I'm using WinCairo as the canary in the coal mine here. It overrides the directory.
Note You need to log in before you can comment on or make changes to this bug.