Bug 196721

Summary:

LICM incorrectly assumes it'll never insert a node which provably OSR exits

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none

Description Saam Barati 2019-04-08 19:20:32 PDT

We might insert code that provably exits. We should gracefully handle this in LICM instead of asserting it doesn't happen.

Comment 1 Saam Barati 2019-04-08 19:56:30 PDT

<rdar://problem/49556479>

Comment 2 Saam Barati 2019-04-08 19:58:17 PDT

Created attachment 367020 [details]
patch

Comment 3 Saam Barati 2019-04-08 19:59:18 PDT

Created attachment 367021 [details]
patch

Comment 4 WebKit Commit Bot 2019-04-23 19:14:28 PDT

Comment on attachment 367021 [details]
patch

Clearing flags on attachment: 367021

Committed r244579: <https://trac.webkit.org/changeset/244579>

Comment 5 WebKit Commit Bot 2019-04-23 19:14:30 PDT

All reviewed patches have been landed.  Closing bug.