Bug 196721

Summary: LICM incorrectly assumes it'll never insert a node which provably OSR exits
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Saam Barati
Reported 2019-04-08 19:20:32 PDT
We might insert code that provably exits. We should gracefully handle this in LICM instead of asserting it doesn't happen.
Attachments
patch (5.51 KB, patch)
2019-04-08 19:58 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (5.51 KB, patch)
2019-04-08 19:59 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-04-08 19:56:30 PDT
<rdar://problem/49556479>
Saam Barati
Comment 2 2019-04-08 19:58:17 PDT
Created attachment 367020 [details] patch
Saam Barati
Comment 3 2019-04-08 19:59:18 PDT
Created attachment 367021 [details] patch
WebKit Commit Bot
Comment 4 2019-04-23 19:14:28 PDT
Comment on attachment 367021 [details] patch Clearing flags on attachment: 367021 Committed r244579: <https://trac.webkit.org/changeset/244579>
WebKit Commit Bot
Comment 5 2019-04-23 19:14:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.