| Summary: | [CMake] CMAKE_BINARY_DIR should always be a PRIVATE include directory | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||||||||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, benjamin, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, Hironori.Fujii, mcatanzaro, ryuan.choi, sergio | ||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Created attachment 371037 [details]
Patch
Created attachment 371039 [details]
Patch
Created attachment 371040 [details]
Patch
Created attachment 371054 [details]
Patch
Comment on attachment 371054 [details]
Patch
r=me if EWS is happy
Comment on attachment 371054 [details] Patch Attachment 371054 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12339576 New failing tests: webgl/2.0.0/conformance/textures/misc/origin-clean-conformance.html Created attachment 371057 [details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371054 [details] Patch Attachment 371054 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12340114 New failing tests: fast/block/float/float-with-anonymous-previous-sibling.html Created attachment 371067 [details]
Archive of layout-test-results from ews215 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 397364 [details]
WIP Patch
Created attachment 397370 [details]
Patch
Committed r260593: <https://trac.webkit.org/changeset/260593> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397370 [details]. |
Currently ${CMAKE_BINARY_DIR} is a public include of WTF so it ends up being propagated to all targets dependent on it.