Bug 196706

Summary: [CMake] WTF derived sources should only be referenced inside WTF
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 196704    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Don Olmstead 2019-04-08 14:13:27 PDT 
Anything outside of Source/WTF should NOT be touching WTF's derived sources.
Comment 1 Don Olmstead 2019-04-08 14:23:21 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2019-04-08 14:33:07 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2019-04-08 14:45:22 PDT Comment hidden (obsolete)
Comment 4 Don Olmstead 2019-04-08 14:54:07 PDT Comment hidden (obsolete)
Comment 5 Don Olmstead 2019-04-09 10:13:41 PDT 
Created attachment 367048 [details]
Patch

Rebasing patch
Comment 6 Don Olmstead 2019-04-09 10:57:28 PDT 
Created attachment 367053 [details]
Patch
Comment 7 Konstantin Tokarev 2019-04-09 11:11:11 PDT 
Comment on attachment 367053 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367053&action=review

> Source/WTF/wtf/PlatformJSCOnly.cmake:-79
> -    list(APPEND WTF_INCLUDE_DIRECTORIES

What happened to contents of WTF_INCLUDE_DIRECTORIES? How are those files included now?
Comment 8 Don Olmstead 2019-04-09 12:03:14 PDT 
Comment on attachment 367053 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367053&action=review

> Source/WTF/wtf/CMakeLists.txt:468
> +    "${WTF_DERIVED_SOURCES_DIR}"

They moved up here.

>> Source/WTF/wtf/PlatformJSCOnly.cmake:-79
>> -    list(APPEND WTF_INCLUDE_DIRECTORIES
> 
> What happened to contents of WTF_INCLUDE_DIRECTORIES? How are those files included now?

Its included in the root CMakeLists.txt. See comment for the location.

> Source/WTF/wtf/PlatformJSCOnly.cmake:-125
> -if (APPLE)
> -    list(APPEND WTF_INCLUDE_DIRECTORIES
> -        "${WTF_DIR}/icu"
> -    )
> -endif ()

This should've been removed in the last patch. Just caught it here.
Comment 9 Konstantin Tokarev 2019-04-09 12:03:25 PDT 
Comment on attachment 367053 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367053&action=review

>> Source/WTF/wtf/PlatformJSCOnly.cmake:-79
>> -    list(APPEND WTF_INCLUDE_DIRECTORIES
> 
> What happened to contents of WTF_INCLUDE_DIRECTORIES? How are those files included now?

I see, it went to WTF_PRIVATE_INCLUDE_DIRECTORIES
Comment 10 WebKit Commit Bot 2019-04-09 12:32:14 PDT 
Comment on attachment 367053 [details]
Patch

Clearing flags on attachment: 367053

Committed r244090: <https://trac.webkit.org/changeset/244090>
Comment 11 WebKit Commit Bot 2019-04-09 12:32:15 PDT 
All reviewed patches have been landed.  Closing bug.