RESOLVED FIXED 196706
[CMake] WTF derived sources should only be referenced inside WTF 
https://bugs.webkit.org/show_bug.cgi?id=196706
Summary [CMake] WTF derived sources should only be referenced inside WTF
Don Olmstead
Reported 2019-04-08 14:13:27 PDT
Anything outside of Source/WTF should NOT be touching WTF's derived sources.
Attachments
Patch (11.75 KB, patch)
2019-04-08 14:23 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (12.47 KB, patch)
2019-04-08 14:33 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (12.90 KB, patch)
2019-04-08 14:45 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (12.70 KB, patch)
2019-04-08 14:54 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (7.88 KB, patch)
2019-04-09 10:13 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (7.19 KB, patch)
2019-04-09 10:57 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-04-08 14:23:21 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2019-04-08 14:33:07 PDT Comment hidden (obsolete)
Don Olmstead
Comment 3 2019-04-08 14:45:22 PDT Comment hidden (obsolete)
Don Olmstead
Comment 4 2019-04-08 14:54:07 PDT Comment hidden (obsolete)
Don Olmstead
Comment 5 2019-04-09 10:13:41 PDT
Created attachment 367048 [details] Patch Rebasing patch
Don Olmstead
Comment 6 2019-04-09 10:57:28 PDT
Created attachment 367053 [details] Patch
Konstantin Tokarev
Comment 7 2019-04-09 11:11:11 PDT
Comment on attachment 367053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367053&action=review > Source/WTF/wtf/PlatformJSCOnly.cmake:-79 > - list(APPEND WTF_INCLUDE_DIRECTORIES What happened to contents of WTF_INCLUDE_DIRECTORIES? How are those files included now?
Don Olmstead
Comment 8 2019-04-09 12:03:14 PDT
Comment on attachment 367053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367053&action=review > Source/WTF/wtf/CMakeLists.txt:468 > + "${WTF_DERIVED_SOURCES_DIR}" They moved up here. >> Source/WTF/wtf/PlatformJSCOnly.cmake:-79 >> - list(APPEND WTF_INCLUDE_DIRECTORIES > > What happened to contents of WTF_INCLUDE_DIRECTORIES? How are those files included now? Its included in the root CMakeLists.txt. See comment for the location. > Source/WTF/wtf/PlatformJSCOnly.cmake:-125 > -if (APPLE) > - list(APPEND WTF_INCLUDE_DIRECTORIES > - "${WTF_DIR}/icu" > - ) > -endif () This should've been removed in the last patch. Just caught it here.
Konstantin Tokarev
Comment 9 2019-04-09 12:03:25 PDT
Comment on attachment 367053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367053&action=review >> Source/WTF/wtf/PlatformJSCOnly.cmake:-79 >> - list(APPEND WTF_INCLUDE_DIRECTORIES > > What happened to contents of WTF_INCLUDE_DIRECTORIES? How are those files included now? I see, it went to WTF_PRIVATE_INCLUDE_DIRECTORIES
WebKit Commit Bot
Comment 10 2019-04-09 12:32:14 PDT
Comment on attachment 367053 [details] Patch Clearing flags on attachment: 367053 Committed r244090: <https://trac.webkit.org/changeset/244090>
WebKit Commit Bot
Comment 11 2019-04-09 12:32:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.