Bug 196692

Summary: Lazily construct Navigator serviceWorker
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=190060
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2019-04-08 08:51:38 PDT
Lazily construct Navigator serviceWorker
Attachments
Patch (5.48 KB, patch)
2019-04-08 09:02 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.53 KB, patch)
2019-04-08 10:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-04-08 09:02:27 PDT
Created attachment 366939 [details] Patch
Geoffrey Garen
Comment 2 2019-04-08 10:26:28 PDT
Comment on attachment 366939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366939&action=review > Source/WebCore/page/NavigatorBase.cpp:150 > +ServiceWorkerContainer* NavigatorBase::serviceWorkerIfAny() I think we agreed, in WebKit style, to call functions like this "serviceWorkerIfExists". It's not my very favorite name, but I'd like us to follow the consensus style here.
youenn fablet
Comment 3 2019-04-08 10:36:06 PDT
Created attachment 366951 [details] Patch
WebKit Commit Bot
Comment 4 2019-04-08 13:51:26 PDT
Comment on attachment 366951 [details] Patch Clearing flags on attachment: 366951 Committed r244043: <https://trac.webkit.org/changeset/244043>
WebKit Commit Bot
Comment 5 2019-04-08 13:51:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-04-08 13:53:43 PDT
<rdar://problem/49709802>
Note You need to log in before you can comment on or make changes to this bug.