| Summary: | Lazily construct Navigator serviceWorker | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=190060 | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2019-04-08 08:51:38 PDT
Created attachment 366939 [details]
Patch
Comment on attachment 366939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366939&action=review > Source/WebCore/page/NavigatorBase.cpp:150 > +ServiceWorkerContainer* NavigatorBase::serviceWorkerIfAny() I think we agreed, in WebKit style, to call functions like this "serviceWorkerIfExists". It's not my very favorite name, but I'd like us to follow the consensus style here. Created attachment 366951 [details]
Patch
Comment on attachment 366951 [details] Patch Clearing flags on attachment: 366951 Committed r244043: <https://trac.webkit.org/changeset/244043> All reviewed patches have been landed. Closing bug. |