Bug 196692 - Lazily construct Navigator serviceWorker
Summary: Lazily construct Navigator serviceWorker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-08 08:51 PDT by youenn fablet
Modified: 2019-04-08 13:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.48 KB, patch)
2019-04-08 09:02 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2019-04-08 10:36 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-04-08 08:51:38 PDT
Lazily construct Navigator serviceWorker
Comment 1 youenn fablet 2019-04-08 09:02:27 PDT
Created attachment 366939 [details]
Patch
Comment 2 Geoffrey Garen 2019-04-08 10:26:28 PDT
Comment on attachment 366939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366939&action=review

> Source/WebCore/page/NavigatorBase.cpp:150
> +ServiceWorkerContainer* NavigatorBase::serviceWorkerIfAny()

I think we agreed, in WebKit style, to call functions like this "serviceWorkerIfExists". It's not my very favorite name, but I'd like us to follow the consensus style here.
Comment 3 youenn fablet 2019-04-08 10:36:06 PDT
Created attachment 366951 [details]
Patch
Comment 4 WebKit Commit Bot 2019-04-08 13:51:26 PDT
Comment on attachment 366951 [details]
Patch

Clearing flags on attachment: 366951

Committed r244043: <https://trac.webkit.org/changeset/244043>
Comment 5 WebKit Commit Bot 2019-04-08 13:51:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-08 13:53:43 PDT
<rdar://problem/49709802>