Bug 196674

Summary: [ews-build] Do not upload archive when Compile Fails
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dewei_zhu, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-04-06 04:05:11 PDT
When compiling webkit fails, ews unapply the patch and compiles clean tree. However after compiling clean tree, it should not upload the archive from clean tree. In these builds, ews uploaded the archive for clean tree and trigerred API tests which passed, these api test results would be misleading since they did not test the right archive. https://ews-build.webkit.org/#/builders/7/builds/229 https://ews-build.webkit.org/#/builders/7/builds/246 https://ews-build.webkit.org/#/builders/7/builds/249
Attachments
Patch (2.84 KB, patch)
2019-04-06 04:22 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-06 04:22:23 PDT
Created attachment 366884 [details] Patch
Alexey Proskuryakov
Comment 2 2019-04-08 09:03:06 PDT
Comment on attachment 366884 [details] Patch It makes me sad that we don't have tests for such issues.
WebKit Commit Bot
Comment 3 2019-04-08 09:32:17 PDT
Comment on attachment 366884 [details] Patch Clearing flags on attachment: 366884 Committed r244021: <https://trac.webkit.org/changeset/244021>
WebKit Commit Bot
Comment 4 2019-04-08 09:32:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-04-08 09:33:20 PDT
<rdar://problem/49698545>
Note You need to log in before you can comment on or make changes to this bug.