Bug 196650

Summary:

Clear Cache Storage structures before removing all related files

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196467

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2019-04-05 10:58:25 PDT

Clear Cache Storage structures before removing all related files.

Comment 1 youenn fablet 2019-04-05 11:00:29 PDT

Created attachment 366828 [details]
Patch

Comment 2 youenn fablet 2019-04-09 10:34:47 PDT

Ping review?

Comment 3 WebKit Commit Bot 2019-04-10 15:59:19 PDT

Comment on attachment 366828 [details]
Patch

Clearing flags on attachment: 366828

Committed r244162: <https://trac.webkit.org/changeset/244162>

Comment 4 WebKit Commit Bot 2019-04-10 15:59:21 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-04-10 16:01:03 PDT

<rdar://problem/49794288>

Comment 6 Alex Christensen 2019-04-16 15:27:17 PDT

Comment on attachment 366828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366828&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:528
> +            return;

We need to call the completion handler here :(