| Summary: | Element::isFocusable() debug asserts too frequently | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, cmarcelo, commit-queue, conrad_shultz, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, koivisto, simon.fraser | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2019-04-04 16:46:27 PDT
Created attachment 366770 [details]
Disables the assertion
Comment on attachment 366770 [details] Disables the assertion View in context: https://bugs.webkit.org/attachment.cgi?id=366770&action=review Can you cite a bug report with steps to reproduce in this FIXME? If we just keep an abstract FIXME, we're preventing future developers from adding that assertion back. > Source/WebCore/dom/Element.cpp:556 > + // FIXME: We should be ablet to assert !needsStyleRecalc() || !document().childNeedsStyleRecalc(). able (In reply to Geoffrey Garen from comment #2) > Comment on attachment 366770 [details] > Disables the assertion > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366770&action=review > > Can you cite a bug report with steps to reproduce in this FIXME? Apparently this happens on Gmail and Microsoft Exchange (website). I can add that to FIXME. Created attachment 366773 [details]
Updated the comment
Comment on attachment 366773 [details]
Updated the comment
r=me
Comment on attachment 366773 [details] Updated the comment Clearing flags on attachment: 366773 Committed r243923: <https://trac.webkit.org/changeset/243923> All reviewed patches have been landed. Closing bug. |