Bug 196634 - Element::isFocusable() debug asserts too frequently
Summary: Element::isFocusable() debug asserts too frequently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-04 16:46 PDT by Ryosuke Niwa
Modified: 2019-04-04 18:09 PDT (History)
11 users (show)

See Also:


Attachments
Disables the assertion (1.38 KB, patch)
2019-04-04 16:47 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Updated the comment (1.46 KB, patch)
2019-04-04 16:56 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-04-04 16:46:27 PDT
Element::isFocusable() debug asserts too frequently
Comment 1 Ryosuke Niwa 2019-04-04 16:47:12 PDT
Created attachment 366770 [details]
Disables the assertion
Comment 2 Geoffrey Garen 2019-04-04 16:52:10 PDT
Comment on attachment 366770 [details]
Disables the assertion

View in context: https://bugs.webkit.org/attachment.cgi?id=366770&action=review

Can you cite a bug report with steps to reproduce in this FIXME?

If we just keep an abstract FIXME, we're preventing future developers from adding that assertion back.

> Source/WebCore/dom/Element.cpp:556
> +        // FIXME: We should be ablet to assert !needsStyleRecalc() || !document().childNeedsStyleRecalc().

able
Comment 3 Ryosuke Niwa 2019-04-04 16:54:58 PDT
(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 366770 [details]
> Disables the assertion
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366770&action=review
> 
> Can you cite a bug report with steps to reproduce in this FIXME?

Apparently this happens on Gmail and Microsoft Exchange (website). I can add that to FIXME.
Comment 4 Conrad Shultz 2019-04-04 16:55:07 PDT
rdar://problem/45729622
Comment 5 Ryosuke Niwa 2019-04-04 16:56:23 PDT
Created attachment 366773 [details]
Updated the comment
Comment 6 Geoffrey Garen 2019-04-04 16:58:16 PDT
Comment on attachment 366773 [details]
Updated the comment

r=me
Comment 7 Ryosuke Niwa 2019-04-04 18:09:45 PDT
Comment on attachment 366773 [details]
Updated the comment

Clearing flags on attachment: 366773

Committed r243923: <https://trac.webkit.org/changeset/243923>
Comment 8 Ryosuke Niwa 2019-04-04 18:09:47 PDT
All reviewed patches have been landed.  Closing bug.