| Summary: | [Web GPU] Fix Web GPU experimental feature on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||||
| Component: | New Bugs | Assignee: | Justin Fan <justin_fan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, jonlee, keith_miller, mark.lam, mmaxfield, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Justin Fan
2019-04-04 15:43:16 PDT
Created attachment 366766 [details]
Patch
Created attachment 366768 [details]
Patch
Comment on attachment 366768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366768&action=review > Source/JavaScriptCore/ChangeLog:8 > + Properly make Web GPU available on iOS 11+. Are we running anything on this version? I think it's ok to just go with the latest. (In reply to Jon Lee from comment #3) > Comment on attachment 366768 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366768&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + Properly make Web GPU available on iOS 11+. > > Are we running anything on this version? I think it's ok to just go with the > latest. What about other iOS browser devs that may want to ship Web GPU on older iOS? Right now, all iOS features Web GPU relies on are available on 11 and above. Comment on attachment 366768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366768&action=review >>> Source/JavaScriptCore/ChangeLog:8 >>> + Properly make Web GPU available on iOS 11+. >> >> Are we running anything on this version? I think it's ok to just go with the latest. > > What about other iOS browser devs that may want to ship Web GPU on older iOS? Right now, all iOS features Web GPU relies on are available on 11 and above. WebGPU should work on all versions that we are mechanically capable of shipping it on. Comment on attachment 366768 [details] Patch Clearing flags on attachment: 366768 Committed r244050: <https://trac.webkit.org/changeset/244050> All reviewed patches have been landed. Closing bug. |