Bug 196632

Summary: [Web GPU] Fix Web GPU experimental feature on iOS
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, jonlee, keith_miller, mark.lam, mmaxfield, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Justin Fan
Reported 2019-04-04 15:43:16 PDT
[Web GPU] Fix Web GPU experimental feature on iOS
Attachments
Patch (17.02 KB, patch)
2019-04-04 15:50 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (15.98 KB, patch)
2019-04-04 16:19 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-04-04 15:50:31 PDT
Created attachment 366766 [details] Patch
Justin Fan
Comment 2 2019-04-04 16:19:19 PDT
Created attachment 366768 [details] Patch
Jon Lee
Comment 3 2019-04-04 18:03:52 PDT
Comment on attachment 366768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366768&action=review > Source/JavaScriptCore/ChangeLog:8 > + Properly make Web GPU available on iOS 11+. Are we running anything on this version? I think it's ok to just go with the latest.
Justin Fan
Comment 4 2019-04-04 18:23:32 PDT
(In reply to Jon Lee from comment #3) > Comment on attachment 366768 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366768&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + Properly make Web GPU available on iOS 11+. > > Are we running anything on this version? I think it's ok to just go with the > latest. What about other iOS browser devs that may want to ship Web GPU on older iOS? Right now, all iOS features Web GPU relies on are available on 11 and above.
Myles C. Maxfield
Comment 5 2019-04-08 14:37:51 PDT
Comment on attachment 366768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366768&action=review >>> Source/JavaScriptCore/ChangeLog:8 >>> + Properly make Web GPU available on iOS 11+. >> >> Are we running anything on this version? I think it's ok to just go with the latest. > > What about other iOS browser devs that may want to ship Web GPU on older iOS? Right now, all iOS features Web GPU relies on are available on 11 and above. WebGPU should work on all versions that we are mechanically capable of shipping it on.
WebKit Commit Bot
Comment 6 2019-04-08 15:11:07 PDT
Comment on attachment 366768 [details] Patch Clearing flags on attachment: 366768 Committed r244050: <https://trac.webkit.org/changeset/244050>
WebKit Commit Bot
Comment 7 2019-04-08 15:11:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-04-08 15:12:19 PDT
<rdar://problem/49713476>
Note You need to log in before you can comment on or make changes to this bug.