| Summary: | [ews-app] status-bubble should display position in queue | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, kocsen_chung, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2019-04-04 08:59:41 PDT
Created attachment 367158 [details]
WIP
Comment on attachment 367158 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=367158&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:64 > + bubble["queue_position"] = queue_position nit: inconsistent use of `"` and `'`. Seems like most of it is `'` so we can stick to that. > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:178 > + previously_sent_patches = set(Patch.objects.filter(modified__gte=from_timestamp).filter(sent_to_buildbot=True).filter(obsolete=False).filter(modified__lt=patch.modified)) nit: I think it would be more readable if the filters are above one another. ```python Patch.objects .filter(x) .filter(y) [...] ``` Created attachment 367386 [details]
Proposed patch
Incorporated review comments.
Comment on attachment 367386 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=367386&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:194 > + processed_patch = set([build.patch for build in recent_builds]) should this be "processed_patches" ? > should this be "processed_patches" ?
Yes, changed.
Committed r244284: <https://trac.webkit.org/changeset/244284> |