Bug 196607

Summary: [ews-app] status-bubble should display position in queue
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Proposed patch lforschler: review+

Aakash Jain
Reported 2019-04-04 08:59:41 PDT
While a patch is waiting in queue, ews-app's status-bubble should display its position in queue.
Attachments
WIP (3.24 KB, patch)
2019-04-10 13:51 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Proposed patch (3.69 KB, patch)
2019-04-13 05:58 PDT, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-04-10 13:51:51 PDT
Created attachment 367158 [details] WIP
Kocsen Chung
Comment 2 2019-04-12 10:51:17 PDT
Comment on attachment 367158 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=367158&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:64 > + bubble["queue_position"] = queue_position nit: inconsistent use of `"` and `'`. Seems like most of it is `'` so we can stick to that. > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:178 > + previously_sent_patches = set(Patch.objects.filter(modified__gte=from_timestamp).filter(sent_to_buildbot=True).filter(obsolete=False).filter(modified__lt=patch.modified)) nit: I think it would be more readable if the filters are above one another. ```python Patch.objects .filter(x) .filter(y) [...] ```
Aakash Jain
Comment 3 2019-04-13 05:58:47 PDT
Created attachment 367386 [details] Proposed patch Incorporated review comments.
Lucas Forschler
Comment 4 2019-04-15 13:04:59 PDT
Comment on attachment 367386 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=367386&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:194 > + processed_patch = set([build.patch for build in recent_builds]) should this be "processed_patches" ?
Aakash Jain
Comment 5 2019-04-15 13:18:38 PDT
> should this be "processed_patches" ? Yes, changed.
Aakash Jain
Comment 6 2019-04-15 13:18:51 PDT
Committed r244284: <https://trac.webkit.org/changeset/244284>
Radar WebKit Bug Importer
Comment 7 2019-04-15 13:19:26 PDT
<rdar://problem/49914755>
Note You need to log in before you can comment on or make changes to this bug.