Bug 196602

Summary: [ATK] Cleanup WebKitAccessibleHyperlink
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, mcatanzaro, samuel_white, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2019-04-04 08:13:00 PDT
.
Attachments
Patch (27.96 KB, patch)
2019-04-04 08:19 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (27.97 KB, patch)
2019-04-08 04:45 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-04 08:14:35 PDT
<rdar://problem/49607151>
Carlos Garcia Campos
Comment 2 2019-04-04 08:19:22 PDT
Created attachment 366714 [details] Patch
Carlos Garcia Campos
Comment 3 2019-04-08 04:45:27 PDT
Created attachment 366926 [details] Patch
Michael Catanzaro
Comment 4 2019-04-08 15:13:47 PDT
Comment on attachment 366926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366926&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp:-418 > - static volatile gsize typeVolatile = 0; > - > - if (g_once_init_enter(&typeVolatile)) { > - static const GTypeInfo tinfo = { > - sizeof(WebKitAccessibleHyperlinkClass), > - (GBaseInitFunc) 0, > - (GBaseFinalizeFunc) 0, > - (GClassInitFunc)(GCallback) webkitAccessibleHyperlinkClassInit, > - (GClassFinalizeFunc) 0, > - 0, /* class data */ > - sizeof(WebKitAccessibleHyperlink), /* instance size */ > - 0, /* nb preallocs */ > - (GInstanceInitFunc)(GCallback) webkitAccessibleHyperlinkInit, > - 0 /* value table */ > - }; > - > - static const GInterfaceInfo actionInfo = { > - (GInterfaceInitFunc)(GCallback)atkActionInterfaceInit, > - (GInterfaceFinalizeFunc) 0, 0 > - }; > - > - GType type = g_type_register_static(ATK_TYPE_HYPERLINK, "WebKitAccessibleHyperlink", &tinfo, GTypeFlags(0)); > - g_type_add_interface_static(type, ATK_TYPE_ACTION, &actionInfo); > - > - g_once_init_leave(&typeVolatile, type); > - } Heh, this is *really* old school!
Carlos Garcia Campos
Comment 5 2019-04-09 02:01:42 PDT
Committed r244072: <https://trac.webkit.org/changeset/244072>
Note You need to log in before you can comment on or make changes to this bug.