| Summary: | [JSC] Add dump feature for RandomizingFuzzerAgent | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, ryanhaddad, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2019-04-03 18:10:10 PDT
Created attachment 366685 [details]
Patch
Attachment 366685 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ChangeLog:3: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer, fuzzer, fuzzer, fuzzer [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r243843: <https://trac.webkit.org/changeset/243843> This change broke the Windows build: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/3414 c:\cygwin\home\buildbot\worker\win10-release\build\source\javascriptcore\runtime\randomizingfuzzeragent.cpp(43): error C2027: use of undefined type 'JSC::CodeBlock' (compiling source file C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource-f2e18ffc-27.cpp) [C:\cygwin\home\buildbot\worker\win10-release\build\WebKitBuild\Release\Source\JavaScriptCore\JavaScriptCore.vcxproj] It also broke the CLoop build: https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/13372 ./runtime/RandomizingFuzzerAgent.cpp:43:52: error: member access into incomplete type 'JSC::CodeBlock' ./runtime/RandomizingFuzzerAgent.cpp:43:84: error: member access into incomplete type 'JSC::CodeBlock' Reverted r243843 for reason: Broke CLoop and Windows builds. Committed r243853: <https://trac.webkit.org/changeset/243853> Committed r243857: <https://trac.webkit.org/changeset/243857> |