Bug 196559

Summary:

Undeprecate WKNavigationData

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, ews-watchlist, ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews202 for win-future	none
Patch	ggaren: review+

Alex Christensen

Reported 2019-04-03 14:00:45 PDT

Undeprecate WKNavigationData

Attachments
Patch (2.96 KB, patch) 2019-04-03 14:17 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews202 for win-future (12.87 MB, application/zip) 2019-04-03 16:17 PDT, EWS Watchlist	no flags	Details
Patch (3.00 KB, patch) 2019-04-04 12:25 PDT, Alex Christensen	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-04-03 14:17:12 PDT

Created attachment 366641 [details] Patch

EWS Watchlist

Comment 2 2019-04-03 16:17:11 PDT

Comment on attachment 366641 [details] Patch Attachment 366641 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11756417 New failing tests: js/dom/custom-constructors.html

EWS Watchlist

Comment 3 2019-04-03 16:17:25 PDT

Created attachment 366664 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

Alex Christensen

Comment 4 2019-04-04 12:25:06 PDT

Created attachment 366737 [details] Patch

Alex Christensen

Comment 5 2019-04-05 09:26:33 PDT

EWS failure looks unrelated.

Geoffrey Garen

Comment 6 2019-04-05 15:56:52 PDT

Comment on attachment 366737 [details] Patch r=me

Geoffrey Garen

Comment 7 2019-04-05 15:57:33 PDT

Is this a real issue? Seems unrelated. Ld /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore normal x86_64 cd /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/Source/WebCore export MACOSX_DEPLOYMENT_TARGET=10.13 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -arch x86_64 -dynamiclib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -L/Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks -F/Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/PrivateFrameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks -filelist /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/WebCore.LinkFileList -unexported_symbols_list Configurations/WebCore.unexp -install_name /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/WebCore -mmacosx-version-min=10.13 -dead_strip -Xlinker -object_path_lto -Xlinker /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Obj ects-normal/x86_64/WebCore_lto.o -stdlib=libc++ -fobjc-link-runtime -Wl,-not_for_dyld_shared_cache -lsqlite3 -lobjc -lANGLE -allowable_client WebCoreTestSupport -allowable_client WebKitLegacy -force_load /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/libPAL.a -framework CFNetwork -framework CoreAudio -framework CoreGraphics -framework CoreText -framework Foundation -framework ImageIO -framework Metal -sub_library libobjc -umbrella WebKit -framework AppKit -framework AudioUnit -framework Carbon -framework CoreUI -framework DataDetectorsCore -framework IOSurface -framework VideoToolbox -framework CoreMedia -weak-lwebrtc -framework OpenGL -framework SystemConfiguration -framework Accelerate -framework AudioToolbox -framework IOKit -framework JavaScriptCore -licucore -lobjc /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/libPAL.a -lxml2 -lz -framework QuartzCore -framework Security -compatibility_version 1 -current_version 608.1.13 -Xlinker -dependency_info -Xlinker /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/WebCore_dependency_info.dat -o /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore duplicate symbol __ZN7WebCore15RTCIceTransportnwEm in: /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/RTCIceTransport.o /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource142.o ld: 3 duplicate symbols for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation)

Alex Christensen

Comment 8 2019-04-05 16:06:58 PDT

http://trac.webkit.org/r243951

Radar WebKit Bug Importer

Comment 9 2019-04-05 16:08:39 PDT

<rdar://problem/49660430>

Note You need to log in before you can comment on or make changes to this bug.