| Summary: | Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2019-04-03 09:32:07 PDT
Created attachment 366616 [details]
Patch
Created attachment 366629 [details]
Patch
ping review Comment on attachment 366629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366629&action=review r=me > Source/WebKit/NetworkProcess/NetworkProcess.cpp:466 > + auto& managers = m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] { It seems like it would be even better to have the NetworkSession own its own storage quota. (In reply to Alex Christensen from comment #4) > Comment on attachment 366629 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366629&action=review > > r=me > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:466 > > + auto& managers = m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] { > > It seems like it would be even better to have the NetworkSession own its own > storage quota. It is true that NetworkProcess has 9 HashMap keyed by SessionID... NetworkSession might indeed be a better place to put all these various values. Comment on attachment 366629 [details] Patch Clearing flags on attachment: 366629 Committed r243911: <https://trac.webkit.org/changeset/243911> All reviewed patches have been landed. Closing bug. |