Bug 196543

Summary: Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2019-04-03 09:32:07 PDT
Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
Attachments
Patch (24.88 KB, patch)
2019-04-03 09:47 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (27.85 KB, patch)
2019-04-03 12:11 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-04-03 09:47:11 PDT
Created attachment 366616 [details] Patch
youenn fablet
Comment 2 2019-04-03 12:11:03 PDT
Created attachment 366629 [details] Patch
youenn fablet
Comment 3 2019-04-04 14:00:02 PDT
ping review
Alex Christensen
Comment 4 2019-04-04 14:29:31 PDT
Comment on attachment 366629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366629&action=review r=me > Source/WebKit/NetworkProcess/NetworkProcess.cpp:466 > + auto& managers = m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] { It seems like it would be even better to have the NetworkSession own its own storage quota.
youenn fablet
Comment 5 2019-04-04 14:39:00 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 366629 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366629&action=review > > r=me > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:466 > > + auto& managers = m_storageQuotaManagers.ensure(parameters.networkSessionParameters.sessionID, [] { > > It seems like it would be even better to have the NetworkSession own its own > storage quota. It is true that NetworkProcess has 9 HashMap keyed by SessionID... NetworkSession might indeed be a better place to put all these various values.
WebKit Commit Bot
Comment 6 2019-04-04 15:07:15 PDT
Comment on attachment 366629 [details] Patch Clearing flags on attachment: 366629 Committed r243911: <https://trac.webkit.org/changeset/243911>
WebKit Commit Bot
Comment 7 2019-04-04 15:07:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-04-04 15:08:21 PDT
<rdar://problem/49624690>
Note You need to log in before you can comment on or make changes to this bug.