Bug 196524

Summary: Add a test for DOMCache on multiple browsing in case of private browsing
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews549 for win-future none

youenn fablet
Reported 2019-04-02 20:02:33 PDT
Add a test for DOMCache on multiple browsing in case of private browsing
Attachments
Patch (3.70 KB, patch)
2019-04-02 20:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews549 for win-future (13.29 MB, application/zip)
2019-04-02 23:13 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-04-02 20:03:30 PDT
Created attachment 366570 [details] Patch
youenn fablet
Comment 2 2019-04-02 20:03:54 PDT
<rdar://problem/48380454>
EWS Watchlist
Comment 3 2019-04-02 20:07:08 PDT
Attachment 366570 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1275: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1290: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1292: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1307: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 4 2019-04-02 23:13:39 PDT
Comment on attachment 366570 [details] Patch Attachment 366570 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11747740 New failing tests: fast/history/link-inside-not-inside-any.html fast/history/multiple-classes-visited.html fast/history/link-inside-not.html fast/history/link-inside-any.html
EWS Watchlist
Comment 5 2019-04-02 23:13:42 PDT
Created attachment 366581 [details] Archive of layout-test-results from ews549 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews549 Port: win-future Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit
youenn fablet
Comment 6 2019-04-03 08:26:35 PDT
Comment on attachment 366570 [details] Patch error is unrelated
WebKit Commit Bot
Comment 7 2019-04-03 10:54:49 PDT
Comment on attachment 366570 [details] Patch Clearing flags on attachment: 366570 Committed r243814: <https://trac.webkit.org/changeset/243814>
WebKit Commit Bot
Comment 8 2019-04-03 10:54:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.