Bug 196514

Summary: HTML Parser: Remove conditional parsing of <noembed> content
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/multipage/parsing.html#parsing-html-fragments:noembed
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-04-02 16:41:19 PDT
Our HTML Parser has raw text handling for <noembed> content only if plugins are runnable. However, the HTML specification doesn't ask such behavior [1], and it doesn't match to our HTML serializer. We should always handle it as raw text. Blink already made this change in https://chromium-review.googlesource.com/c/1477556. [1] https://html.spec.whatwg.org/multipage/parsing.html#parsing-html-fragments:noembed
Attachments
Patch (7.03 KB, patch)
2019-04-02 16:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-04-02 16:45:40 PDT
Created attachment 366551 [details] Patch
Geoffrey Garen
Comment 2 2019-04-02 16:59:57 PDT
Comment on attachment 366551 [details] Patch r=me
WebKit Commit Bot
Comment 3 2019-04-02 18:55:43 PDT
Comment on attachment 366551 [details] Patch Clearing flags on attachment: 366551 Committed r243782: <https://trac.webkit.org/changeset/243782>
WebKit Commit Bot
Comment 4 2019-04-02 18:55:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-04-02 18:56:21 PDT
<rdar://problem/49544147>
Note You need to log in before you can comment on or make changes to this bug.