Bug 196513

Summary:

Web Inspector: Remote Inspector indicate callback should always happen on the main thread

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	hi: review+
[PATCH] For Bots	none

Description Joseph Pecoraro 2019-04-02 16:35:14 PDT

Remote Inspector indicate callback should always happen on the main thread

Indicator show/hide affect the view hierarchy.

When there was a WebThread this would happen on the WebThread, but it would be better to happen on the MainThread with the WebThreadLock.

Comment 1 Joseph Pecoraro 2019-04-02 16:35:24 PDT

<rdar://problem/49498284>

Comment 2 Joseph Pecoraro 2019-04-02 16:37:09 PDT

Created attachment 366547 [details]
[PATCH] Proposed Fix

Comment 3 Devin Rousso 2019-04-02 16:41:49 PDT

Comment on attachment 366547 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=366547&action=review

r=me, looks good to me (especially because I was there when he was working on it)

> Source/WebCore/ChangeLog:11
> +        When we have a WebThread, don't just run on the WebThread run

NIT: there should be a semicolon between "WebThread" and "run".

Comment 4 Joseph Pecoraro 2019-04-02 16:43:55 PDT

Created attachment 366550 [details]
[PATCH] For Bots

Comment 5 WebKit Commit Bot 2019-04-03 05:42:44 PDT

Comment on attachment 366550 [details]
[PATCH] For Bots

Clearing flags on attachment: 366550

Committed r243795: <https://trac.webkit.org/changeset/243795>

Comment 6 BJ Burg 2019-04-03 11:52:10 PDT

Comment on attachment 366547 [details]
[PATCH] Proposed Fix

LGTM