| Summary: | [Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||||
| Component: | New Bugs | Assignee: | Justin Fan <justin_fan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, mmaxfield, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Justin Fan
2019-04-01 17:19:54 PDT
Created attachment 366450 [details]
Patch
Created attachment 366462 [details]
Patch
Comment on attachment 366462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366462&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:450 > + [descriptor setBlendingEnabled:YES]; Can we get some extra perf here by turning this off in some circumstances? Comment on attachment 366462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366462&action=review >> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:450 >> + [descriptor setBlendingEnabled:YES]; > > Can we get some extra perf here by turning this off in some circumstances? There might be some side-effects by turning this off (maybe no depth testing?) so perhaps we should just file a follow-up bug to do an investigation. Comment on attachment 366462 [details] Patch Clearing flags on attachment: 366462 Committed r243755: <https://trac.webkit.org/changeset/243755> All reviewed patches have been landed. Closing bug. |