RESOLVED FIXED 196474
[Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor 
https://bugs.webkit.org/show_bug.cgi?id=196474
Summary [Web GPU] Implement blend states and color write mask for GPUColorStateDescr...
Justin Fan
Reported 2019-04-01 17:19:54 PDT
[Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor
Attachments
Patch (42.87 KB, patch)
2019-04-01 17:34 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (44.84 KB, patch)
2019-04-01 20:07 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-04-01 17:34:14 PDT
Created attachment 366450 [details] Patch
Justin Fan
Comment 2 2019-04-01 20:07:56 PDT
Created attachment 366462 [details] Patch
Myles C. Maxfield
Comment 3 2019-04-02 12:40:18 PDT
Comment on attachment 366462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366462&action=review > Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:450 > + [descriptor setBlendingEnabled:YES]; Can we get some extra perf here by turning this off in some circumstances?
Myles C. Maxfield
Comment 4 2019-04-02 12:41:11 PDT
Comment on attachment 366462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366462&action=review >> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:450 >> + [descriptor setBlendingEnabled:YES]; > > Can we get some extra perf here by turning this off in some circumstances? There might be some side-effects by turning this off (maybe no depth testing?) so perhaps we should just file a follow-up bug to do an investigation.
WebKit Commit Bot
Comment 5 2019-04-02 13:00:01 PDT
Comment on attachment 366462 [details] Patch Clearing flags on attachment: 366462 Committed r243755: <https://trac.webkit.org/changeset/243755>
WebKit Commit Bot
Comment 6 2019-04-02 13:00:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-04-02 13:48:26 PDT
<rdar://problem/49532669>
Note You need to log in before you can comment on or make changes to this bug.