Bug 196474 - [Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor
Summary: [Web GPU] Implement blend states and color write mask for GPUColorStateDescr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-01 17:19 PDT by Justin Fan
Modified: 2019-04-02 13:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (42.87 KB, patch)
2019-04-01 17:34 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (44.84 KB, patch)
2019-04-01 20:07 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-04-01 17:19:54 PDT 
[Web GPU] Implement blend states and color write mask for  GPUColorStateDescriptor
Comment 1 Justin Fan 2019-04-01 17:34:14 PDT 
Created attachment 366450 [details]
Patch
Comment 2 Justin Fan 2019-04-01 20:07:56 PDT 
Created attachment 366462 [details]
Patch
Comment 3 Myles C. Maxfield 2019-04-02 12:40:18 PDT 
Comment on attachment 366462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366462&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:450
> +        [descriptor setBlendingEnabled:YES];

Can we get some extra perf here by turning this off in some circumstances?
Comment 4 Myles C. Maxfield 2019-04-02 12:41:11 PDT 
Comment on attachment 366462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366462&action=review

>> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:450
>> +        [descriptor setBlendingEnabled:YES];
> 
> Can we get some extra perf here by turning this off in some circumstances?

There might be some side-effects by turning this off (maybe no depth testing?) so perhaps we should just file a follow-up bug to do an investigation.
Comment 5 WebKit Commit Bot 2019-04-02 13:00:01 PDT 
Comment on attachment 366462 [details]
Patch

Clearing flags on attachment: 366462

Committed r243755: <https://trac.webkit.org/changeset/243755>
Comment 6 WebKit Commit Bot 2019-04-02 13:00:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-04-02 13:48:26 PDT 
<rdar://problem/49532669>