Bug 196453

Summary: Web Inspector: DOMDebugger: disabling a breakpoint for a specific event listener removes it from the UI
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-04-01 12:23:02 PDT
If I set a breakpoint on a specific node's event listener for a specific event, disabling that breakpoint shouldn't delete the UI in the Debugger/Sources tab.
Attachments
Patch (10.69 KB, patch)
2019-04-01 14:36 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-01 12:23:17 PDT Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 2 2019-04-01 12:23:19 PDT
<rdar://problem/49489318>
Devin Rousso
Comment 3 2019-04-01 14:36:43 PDT
Created attachment 366423 [details] Patch
Joseph Pecoraro
Comment 4 2019-04-01 16:10:55 PDT
Comment on attachment 366423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366423&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:309 > + WI.domManager.removeEventListenerBreakpointsForNode(domNode); Nice!
WebKit Commit Bot
Comment 5 2019-04-01 16:38:50 PDT
Comment on attachment 366423 [details] Patch Clearing flags on attachment: 366423 Committed r243722: <https://trac.webkit.org/changeset/243722>
WebKit Commit Bot
Comment 6 2019-04-01 16:38:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.