Bug 196433

Summary: [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, bfulgham, cdumez, cmarcelo, commit-queue, david_quesada, dbates, ddkilzer, dino, ews-watchlist, ggaren, japhet, thorton, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202935    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Andy Estes
Reported 2019-03-30 21:18:34 PDT
[iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
Attachments
Patch (62.35 KB, patch)
2019-03-30 21:22 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (64.11 KB, patch)
2019-03-30 21:42 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (64.29 KB, patch)
2019-03-30 22:08 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (64.21 KB, patch)
2019-03-30 23:59 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (64.20 KB, patch)
2019-03-31 09:57 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2019-03-30 21:19:43 PDT
rdar://problem/49293305
Andy Estes
Comment 2 2019-03-30 21:22:59 PDT Comment hidden (obsolete)
Andy Estes
Comment 3 2019-03-30 21:42:35 PDT Comment hidden (obsolete)
Andy Estes
Comment 4 2019-03-30 22:08:52 PDT Comment hidden (obsolete)
Alex Christensen
Comment 5 2019-03-30 22:09:38 PDT
Comment on attachment 366374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366374&action=review > Source/WTF/wtf/NeverDestroyed.h:63 > + T* operator->() { return storagePointer(); } The world will never be the same.
Andy Estes
Comment 6 2019-03-30 23:59:10 PDT Comment hidden (obsolete)
Tim Horton
Comment 7 2019-03-31 00:06:00 PDT
Comment on attachment 366374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366374&action=review > Source/WebCore/platform/network/ios/PreviewConverter.mm:59 > + if (equalLettersIgnoringASCIICase(mimeType, "text/html") || equalLettersIgnoringASCIICase(mimeType, "text/plain")) Surprised we don't have constants for these but it seems like we don't. > Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp:41 > + EXPECT_FALSE(PreviewConverter::supportsMIMEType(String())); > + EXPECT_FALSE(PreviewConverter::supportsMIMEType(emptyString())); Maybe cover at least one non-empty/null falsy one?
Andy Estes
Comment 8 2019-03-31 09:57:53 PDT
Created attachment 366377 [details] Patch
WebKit Commit Bot
Comment 9 2019-03-31 10:37:51 PDT
Comment on attachment 366377 [details] Patch Clearing flags on attachment: 366377 Committed r243682: <https://trac.webkit.org/changeset/243682>
WebKit Commit Bot
Comment 10 2019-03-31 10:37:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.