Bug 196425

Summary: [JSC] JSRunLoopTimer::Manager should be small
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-highsierra
none
Patch darin: review+

Yusuke Suzuki
Reported 2019-03-29 21:50:09 PDT
[JSC] JSRunLoopTimer::Manager should be small
Attachments
Patch (12.65 KB, patch)
2019-03-29 21:50 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-highsierra (2.52 MB, application/zip)
2019-03-29 23:09 PDT, EWS Watchlist 		no flags
Details
Patch (4.93 KB, patch)
2019-03-30 00:11 PDT, Yusuke Suzuki 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-29 21:50:42 PDT
Created attachment 366353 [details] Patch
EWS Watchlist
Comment 2 2019-03-29 23:09:03 PDT
Comment on attachment 366353 [details] Patch Attachment 366353 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11710528 New failing tests: workers/bomb.html
EWS Watchlist
Comment 3 2019-03-29 23:09:04 PDT
Created attachment 366359 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Yusuke Suzuki
Comment 4 2019-03-30 00:11:15 PDT
Created attachment 366361 [details] Patch
Darin Adler
Comment 5 2019-04-01 08:50:17 PDT
Comment on attachment 366361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366361&action=review > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:124 > + PerVMData& data = *entry.value.get(); Normally if we are using the * operator, we don’t also need to call get(). Unless there is some special consideration here. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:202 > + PerVMData& data = *iter->value.get(); Ditto. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:232 > + PerVMData& data = *iter->value.get(); Ditto. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:264 > + PerVMData& data = *iter->value.get(); Ditto. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:282 > + PerVMData& data = *iter->value.get(); Ditto.
Yusuke Suzuki
Comment 6 2019-04-01 11:21:45 PDT
Comment on attachment 366361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366361&action=review >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:124 >> + PerVMData& data = *entry.value.get(); > > Normally if we are using the * operator, we don’t also need to call get(). Unless there is some special consideration here. Thanks, you're right. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:202 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:232 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:264 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:282 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed.
Yusuke Suzuki
Comment 7 2019-04-01 11:34:05 PDT
Committed r243702: <https://trac.webkit.org/changeset/243702>
Radar WebKit Bug Importer
Comment 8 2019-04-01 11:35:18 PDT
<rdar://problem/49487406>
Note You need to log in before you can comment on or make changes to this bug.