| Summary: | [JSC] JSRunLoopTimer::Manager should be small | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2019-03-29 21:50:09 PDT
Created attachment 366353 [details]
Patch
Comment on attachment 366353 [details] Patch Attachment 366353 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11710528 New failing tests: workers/bomb.html Created attachment 366359 [details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 366361 [details]
Patch
Comment on attachment 366361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366361&action=review > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:124 > + PerVMData& data = *entry.value.get(); Normally if we are using the * operator, we don’t also need to call get(). Unless there is some special consideration here. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:202 > + PerVMData& data = *iter->value.get(); Ditto. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:232 > + PerVMData& data = *iter->value.get(); Ditto. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:264 > + PerVMData& data = *iter->value.get(); Ditto. > Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:282 > + PerVMData& data = *iter->value.get(); Ditto. Comment on attachment 366361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366361&action=review >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:124 >> + PerVMData& data = *entry.value.get(); > > Normally if we are using the * operator, we don’t also need to call get(). Unless there is some special consideration here. Thanks, you're right. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:202 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:232 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:264 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed. >> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:282 >> + PerVMData& data = *iter->value.get(); > > Ditto. Fixed. Committed r243702: <https://trac.webkit.org/changeset/243702> |