| Summary: | UnlinkedCodeBlock constructor from cache should initialize m_didOptimize | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||
| Component: | JavaScriptCore | Assignee: | Tadeu Zagallo <tzagallo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tadeu Zagallo
2019-03-29 04:18:43 PDT
Created attachment 366265 [details]
Patch
Comment on attachment 366265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366265&action=review r=me I'm not sure how you found this, but I'm starting to think running all of JetStream 2 with caching could be a good test to add. > Source/JavaScriptCore/ChangeLog:9 > + The UnlinkedCodeBlock constructor in CachedTypes was missing the initialization > + for m_didOptimize, which leads to crashes in CodeBlock::thresholdForJIT. Please add a test. Comment on attachment 366265 [details] Patch Clearing flags on attachment: 366265 Committed r243867: <https://trac.webkit.org/changeset/243867> All reviewed patches have been landed. Closing bug. (In reply to WebKit Commit Bot from comment #3) > Comment on attachment 366265 [details] > Patch > > Clearing flags on attachment: 366265 > > Committed r243867: <https://trac.webkit.org/changeset/243867> No test? (In reply to Saam Barati from comment #6) > (In reply to WebKit Commit Bot from comment #3) > > Comment on attachment 366265 [details] > > Patch > > > > Clearing flags on attachment: 366265 > > > > Committed r243867: <https://trac.webkit.org/changeset/243867> > > No test? Oh, I'm sorry, I don't know how I missed your comment. I'll add a follow-up patch do this bug. |