Bug 196396 - UnlinkedCodeBlock constructor from cache should initialize m_didOptimize
Summary: UnlinkedCodeBlock constructor from cache should initialize m_didOptimize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-29 04:18 PDT by Tadeu Zagallo
Modified: 2019-04-04 07:19 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2019-03-29 04:21 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-03-29 04:18:43 PDT 
...
Comment 1 Tadeu Zagallo 2019-03-29 04:21:21 PDT 
Created attachment 366265 [details]
Patch
Comment 2 Saam Barati 2019-04-03 17:12:53 PDT 
Comment on attachment 366265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366265&action=review

r=me

I'm not sure how you found this, but I'm starting to think running all of JetStream 2 with caching could be a good test to add.

> Source/JavaScriptCore/ChangeLog:9
> +        The UnlinkedCodeBlock constructor in CachedTypes was missing the initialization
> +        for m_didOptimize, which leads to crashes in CodeBlock::thresholdForJIT.

Please add a test.
Comment 3 WebKit Commit Bot 2019-04-04 07:15:26 PDT 
Comment on attachment 366265 [details]
Patch

Clearing flags on attachment: 366265

Committed r243867: <https://trac.webkit.org/changeset/243867>
Comment 4 WebKit Commit Bot 2019-04-04 07:15:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-04 07:16:22 PDT 
<rdar://problem/49605973>
Comment 6 Saam Barati 2019-04-04 07:17:17 PDT 
(In reply to WebKit Commit Bot from comment #3)
> Comment on attachment 366265 [details]
> Patch
> 
> Clearing flags on attachment: 366265
> 
> Committed r243867: <https://trac.webkit.org/changeset/243867>

No test?
Comment 7 Tadeu Zagallo 2019-04-04 07:19:27 PDT 
(In reply to Saam Barati from comment #6)
> (In reply to WebKit Commit Bot from comment #3)
> > Comment on attachment 366265 [details]
> > Patch
> > 
> > Clearing flags on attachment: 366265
> > 
> > Committed r243867: <https://trac.webkit.org/changeset/243867>
> 
> No test?

Oh, I'm sorry, I don't know how I missed your comment. I'll add a follow-up patch do this bug.