RESOLVED FIXED196396
UnlinkedCodeBlock constructor from cache should initialize m_didOptimize 
https://bugs.webkit.org/show_bug.cgi?id=196396
Summary UnlinkedCodeBlock constructor from cache should initialize m_didOptimize
Tadeu Zagallo
Reported 2019-03-29 04:18:43 PDT
...
Attachments
Patch (1.51 KB, patch)
2019-03-29 04:21 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-03-29 04:21:21 PDT
Created attachment 366265 [details] Patch
Saam Barati
Comment 2 2019-04-03 17:12:53 PDT
Comment on attachment 366265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366265&action=review r=me I'm not sure how you found this, but I'm starting to think running all of JetStream 2 with caching could be a good test to add. > Source/JavaScriptCore/ChangeLog:9 > + The UnlinkedCodeBlock constructor in CachedTypes was missing the initialization > + for m_didOptimize, which leads to crashes in CodeBlock::thresholdForJIT. Please add a test.
WebKit Commit Bot
Comment 3 2019-04-04 07:15:26 PDT
Comment on attachment 366265 [details] Patch Clearing flags on attachment: 366265 Committed r243867: <https://trac.webkit.org/changeset/243867>
WebKit Commit Bot
Comment 4 2019-04-04 07:15:27 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-04-04 07:16:22 PDT
<rdar://problem/49605973>
Saam Barati
Comment 6 2019-04-04 07:17:17 PDT
(In reply to WebKit Commit Bot from comment #3) > Comment on attachment 366265 [details] > Patch > > Clearing flags on attachment: 366265 > > Committed r243867: <https://trac.webkit.org/changeset/243867> No test?
Tadeu Zagallo
Comment 7 2019-04-04 07:19:27 PDT
(In reply to Saam Barati from comment #6) > (In reply to WebKit Commit Bot from comment #3) > > Comment on attachment 366265 [details] > > Patch > > > > Clearing flags on attachment: 366265 > > > > Committed r243867: <https://trac.webkit.org/changeset/243867> > > No test? Oh, I'm sorry, I don't know how I missed your comment. I'll add a follow-up patch do this bug.
Note You need to log in before you can comment on or make changes to this bug.