| Summary: | Web Inspector: add fast returns for instrumentation hooks that have no affect before a frontend is connected | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mkwst, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Devin Rousso
2019-03-28 17:22:17 PDT
Created attachment 366228 [details]
Patch
Comment on attachment 366228 [details]
Patch
r=me, nice
Comment on attachment 366228 [details] Patch Attachment 366228 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11697129 New failing tests: http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html Created attachment 366234 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 366303 [details]
Patch
Replace the `ASSERT` with early returns, as there are a lot of different paths to the various console agent functions, and it's far simpler to have the check in the console agent than at every call site.
Comment on attachment 366303 [details] Patch Clearing flags on attachment: 366303 Committed r243663: <https://trac.webkit.org/changeset/243663> All reviewed patches have been landed. Closing bug. |