Bug 196382

Summary:

Web Inspector: add fast returns for instrumentation hooks that have no affect before a frontend is connected

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mkwst, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews114 for mac-highsierra	none
Patch	none

Devin Rousso

Reported 2019-03-28 17:22:17 PDT

Attachments
Patch (16.00 KB, patch) 2019-03-28 17:27 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-highsierra (2.82 MB, application/zip) 2019-03-28 19:31 PDT, EWS Watchlist	no flags	Details
Patch (14.52 KB, patch) 2019-03-29 13:30 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-28 17:22:44 PDT

<rdar://problem/49403417>

Devin Rousso

Comment 2 2019-03-28 17:27:23 PDT

Created attachment 366228 [details] Patch

Joseph Pecoraro

Comment 3 2019-03-28 18:41:39 PDT

Comment on attachment 366228 [details] Patch r=me, nice

EWS Watchlist

Comment 4 2019-03-28 19:31:19 PDT Comment hidden (obsolete)

Comment on attachment 366228 [details] Patch Attachment 366228 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11697129 New failing tests: http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html

EWS Watchlist

Comment 5 2019-03-28 19:31:21 PDT Comment hidden (obsolete)

Created attachment 366234 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 6 2019-03-29 13:30:10 PDT

Created attachment 366303 [details] Patch Replace the `ASSERT` with early returns, as there are a lot of different paths to the various console agent functions, and it's far simpler to have the check in the console agent than at every call site.

WebKit Commit Bot

Comment 7 2019-03-29 14:49:59 PDT

Comment on attachment 366303 [details] Patch Clearing flags on attachment: 366303 Committed r243663: <https://trac.webkit.org/changeset/243663>

WebKit Commit Bot

Comment 8 2019-03-29 14:50:01 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.