Bug 196382 - Web Inspector: add fast returns for instrumentation hooks that have no affect before a frontend is connected
Summary: Web Inspector: add fast returns for instrumentation hooks that have no affect...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-28 17:22 PDT by Devin Rousso
Modified: 2019-03-29 14:50 PDT (History)
11 users (show)

See Also:


Attachments
Patch (16.00 KB, patch)
2019-03-28 17:27 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-highsierra (2.82 MB, application/zip)
2019-03-28 19:31 PDT, EWS Watchlist
no flags Details
Patch (14.52 KB, patch)
2019-03-29 13:30 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-28 17:22:17 PDT
.
Comment 1 Radar WebKit Bug Importer 2019-03-28 17:22:44 PDT
<rdar://problem/49403417>
Comment 2 Devin Rousso 2019-03-28 17:27:23 PDT
Created attachment 366228 [details]
Patch
Comment 3 Joseph Pecoraro 2019-03-28 18:41:39 PDT
Comment on attachment 366228 [details]
Patch

r=me, nice
Comment 4 EWS Watchlist 2019-03-28 19:31:19 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2019-03-28 19:31:21 PDT Comment hidden (obsolete)
Comment 6 Devin Rousso 2019-03-29 13:30:10 PDT
Created attachment 366303 [details]
Patch

Replace the `ASSERT` with early returns, as there are a lot of different paths to the various console agent functions, and it's far simpler to have the check in the console agent than at every call site.
Comment 7 WebKit Commit Bot 2019-03-29 14:49:59 PDT
Comment on attachment 366303 [details]
Patch

Clearing flags on attachment: 366303

Committed r243663: <https://trac.webkit.org/changeset/243663>
Comment 8 WebKit Commit Bot 2019-03-29 14:50:01 PDT
All reviewed patches have been landed.  Closing bug.