Bug 196357 – [ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Shawn Roberts]

The following layout test is failing on iOS Simulator Release WK2

storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html

Probable cause:

Test has been a flaky failure since test was created in https://trac.webkit.org/changeset/195394/webkit

However since changes in https://trac.webkit.org/changeset/242986/webkit . The test is showing up on iOS Simulator for the first time and failing more consistently. Test behavior is different in testing in r242985, and is less flaky in that revision. 

Reproduced with: 

run-webkit-tests storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html --iterations 500 -f --ios-simulator

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fmodern%2Fidbtransaction-objectstore-failures-private.html

Diff:

--- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/idbtransaction-objectstore-failures-private-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/idbtransaction-objectstore-failures-private-actual.txt
@@ -15,7 +15,7 @@
 Caught attempt to access non-existant object store on the transaction
 Caught attempt to access valid object store on a transaction that is already finishing
 put failed (because transaction was aborted)
-First version change transaction unexpected error - [object Event]
+First version change transaction abort
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Radar WebKit Bug Importer]

<rdar://problem/49386836>

[Shawn Roberts]

Marked flaky in https://trac.webkit.org/changeset/243612/webkit while waiting for a fix.

[Sihui Liu]

Created attachment 368242 [details]
Patch

[Geoffrey Garen]

Comment on attachment 368242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368242&action=review

r=me

> Source/WebCore/Modules/indexeddb/IDBTransaction.h:149
> +    bool isEventDispatched() const { return m_eventDispatched; }

Let's call this 

    bool didDispatchAbortOrCommit() const { return m_didDispatchAbortOrCommit; }

[Sihui Liu]

Created attachment 368293 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 368293 [details]
Patch for landing

Clearing flags on attachment: 368293

Committed r244674: <https://trac.webkit.org/changeset/244674>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.