The following layout test is failing on iOS Simulator Release WK2 storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html Probable cause: Test has been a flaky failure since test was created in https://trac.webkit.org/changeset/195394/webkit However since changes in https://trac.webkit.org/changeset/242986/webkit . The test is showing up on iOS Simulator for the first time and failing more consistently. Test behavior is different in testing in r242985, and is less flaky in that revision. Reproduced with: run-webkit-tests storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html --iterations 500 -f --ios-simulator Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fmodern%2Fidbtransaction-objectstore-failures-private.html Diff: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/idbtransaction-objectstore-failures-private-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/storage/indexeddb/modern/idbtransaction-objectstore-failures-private-actual.txt @@ -15,7 +15,7 @@ Caught attempt to access non-existant object store on the transaction Caught attempt to access valid object store on a transaction that is already finishing put failed (because transaction was aborted) -First version change transaction unexpected error - [object Event] +First version change transaction abort PASS successfullyParsed is true TEST COMPLETE
<rdar://problem/49386836>
Marked flaky in https://trac.webkit.org/changeset/243612/webkit while waiting for a fix.
Created attachment 368242 [details] Patch
Comment on attachment 368242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368242&action=review r=me > Source/WebCore/Modules/indexeddb/IDBTransaction.h:149 > + bool isEventDispatched() const { return m_eventDispatched; } Let's call this bool didDispatchAbortOrCommit() const { return m_didDispatchAbortOrCommit; }
Created attachment 368293 [details] Patch for landing
Comment on attachment 368293 [details] Patch for landing Clearing flags on attachment: 368293 Committed r244674: <https://trac.webkit.org/changeset/244674>
All reviewed patches have been landed. Closing bug.