Summary: | [GStreamer] imxvpudecoder detection and handling | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Media | Assignee: | Philippe Normand <pnormand> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2019-03-28 04:27:23 PDT
Created attachment 366165 [details]
Patch
Comment on attachment 366165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366165&action=review > Source/WebCore/ChangeLog:9 > + directviv-uploaded texure returns an RGB value, so there's no need texture > Source/WebCore/ChangeLog:11 > + ImageRotation flag handling. The flat is now computed once only flag > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:858 > + bool shouldWait = m_videoDecoderPlatform == WebKitGstVideoDecoderPlatform::Video4Linux; > auto proxyOperation = > - [shouldWait = m_isVideoDecoderVideo4Linux, pipeline = pipeline()](TextureMapperPlatformLayerProxy& proxy) > + [shouldWait, pipeline = pipeline()](TextureMapperPlatformLayerProxy& proxy) nit: is there any problem in using this in one line? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:294 > + mutable WebKitGstVideoDecoderPlatform m_videoDecoderPlatform; Does this need to be mutable? Comment on attachment 366165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366165&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:294 >> + mutable WebKitGstVideoDecoderPlatform m_videoDecoderPlatform; > > Does this need to be mutable? It indeed does not! Committed r243644: <https://trac.webkit.org/changeset/243644> |